PlanetSquires Forums

Please login or register.

Login with username, password and session length
Advanced search  

Author Topic: WinFBE 3.0.0 BETA 2 some theme colors don't match up with their targets  (Read 129 times)

Bruce Huber

  • Junior Member
  • **
  • Posts: 59

Hey Paul,

Testing WinFBE 3.0.0 BETA 2 themes with the x32 version since the x64 is not working for me.

I copied your dark theme so I could modify it for the colors I want.

I added some color variables to the 4 or 5 that you already have in your dark theme. But whether I use a color variable or RGB n,n,n literals, some of the colors don't change correctly.

For example, whatever I change "editor.text.foreground:" to, the editor text does not change... but that color is applied to the "editor.indentguides.foreground:" in the editor.

Thanks!
CBruce
Logged

SeaVipe

  • Senior Member
  • ***
  • Posts: 437
  • Windows 10

Hi, I've been playing around with dark theme for x64 WinFBE (I don't have a use for the x32 version yet). To see my changes (made with Notepad ++) I found that I must go to Environment Options|Themes And Fonts and select (light) Theme and then select (dark) Theme again and then click OK. Alternatively, closing and then reopening WinFBE also works, but time-consuming.
I've been using an old (very old) version of Paint Shop Pro to help me choose my RGB colours and so far they are pretty much spot on.
I added %LINENUMBER_BG: 38,43,60 as I like to see how close to Col 1 the cursor is :)
Logged
Clive Richey
You're Either Part Of The Solution, Or You're The Problem.
#StaySafe, Always  Keep A Safe #SocialDistance, #WashYourHands Often and please, #StayHome!

Paul Squires

  • Administrator
  • Guru Member
  • *****
  • Posts: 9497
  • Windows 10
    • PlanetSquires Software

Thanks Bruce, yes you are correct, there does seem to be something wrong with the them coloring when values are changed. I am investigating.
Logged
Paul Squires
PlanetSquires Software
WinFBE Editor and Visual Designer

Paul Squires

  • Administrator
  • Guru Member
  • *****
  • Posts: 9497
  • Windows 10
    • PlanetSquires Software

For example, whatever I change "editor.text.foreground:" to, the editor text does not change... but that color is applied to the "editor.indentguides.foreground:" in the editor.

Hi Bruce,

I found the reason why the IndentGuides color was changing. That is now fixed. I still have not isolated why changing the editor.text.foreground value is not being reflected in editor. I have noticed that unchecking the "Syntax Highlighting" option in Environment Options allows the new text foreground to show correctly. So, it looks like there is something in the lexilla.dll code that I need to change.
Logged
Paul Squires
PlanetSquires Software
WinFBE Editor and Visual Designer

Paul Squires

  • Administrator
  • Guru Member
  • *****
  • Posts: 9497
  • Windows 10
    • PlanetSquires Software

Okay, the source of the problem is related to "Identifiers" colors overriding the editor text fore/back colors. I am not sure why I included Identifiers as a Theme color because the default editor.text colors basically cover the same case as an Identifier.

I will be removing the following lines from the Theme files (default light and dark):

editor.identifiers.foreground: %LIGHT_GRAY
editor.identifiers.background: %LIGHT_BLACK
editor.identifiers.bold: false
editor.identifiers.italic: false
editor.identifiers.underline: false
Logged
Paul Squires
PlanetSquires Software
WinFBE Editor and Visual Designer